Skip to content

fix(branding): force light and dark backgrounds on logos and icons (#… - #251

Closed
Ayush-AM wants to merge 1 commit into
webpack:mainfrom
Ayush-AM:fix/issue-243
Closed

fix(branding): force light and dark backgrounds on logos and icons (#…#251
Ayush-AM wants to merge 1 commit into
webpack:mainfrom
Ayush-AM:fix/issue-243

Conversation

@Ayush-AM

@Ayush-AM Ayush-AM commented Aug 19, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Fixes #243.

Summary of Changes

  • Wrapped horizontal and stacked logos for light backgrounds in forced light (#ffffff / bg-white) containers.
  • Wrapped horizontal and stacked logos for dark backgrounds in forced dark (#2b3a42 / bg-[#2b3a42]) containers.
  • Wrapped webpack icon and hex sticker in corresponding forced light/dark background containers.
  • Ensures logos and icons remain legible and visually distinct regardless of active theme mode.

Summary by CodeRabbit

  • Documentation
    • Improved branding asset previews with consistent light and dark background containers.
    • Updated logo and icon tables while preserving SVG and PNG download links.
    • Added contribution documentation covering theme-dependent logo contrast and verification checks.

@vercel

vercel Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview Aug 19, 2026 4:48pm

Request Review

@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: Ayush-AM / name: Ayush Mahajan (6e27ff1)

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 19, 2026
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 64e3d429-9c33-4af2-8f00-25c06dd75397

📥 Commits

Reviewing files that changed from the base of the PR and between df0d506 and 6e27ff1.

📒 Files selected for processing (2)
  • docs/contributions/ISSUE-243.md
  • pages/about/branding.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • webpack/webpack (auto-detected)

Included review availability: Your plan provides up to 3 included reviews per hour; 2 remain after this review.

Walkthrough

The branding guide now renders horizontal logos, stacked logos, icons, and hex stickers inside centered containers with forced light or dark backgrounds. The containers also define padding, rounded corners, and image alt text. SVG and PNG download links remain available. Issue #243 documentation records the contrast problem and verification checks.

Merge Risk: ⚪ Minimal · up to 6e27f

This change updates branding-page presentation to keep logos and icons legible across light and dark themes. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the branding change to force light and dark backgrounds for logos and icons.
Linked Issues check ✅ Passed The branding page changes satisfy issue #243 by adding contrasting backgrounds to logos and icons for theme visibility.
Out of Scope Changes check ✅ Passed The documentation changes are limited to the branding page update and its related contribution documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@moshams272

moshams272 commented Aug 19, 2026

Copy link
Copy Markdown
Member

Thanks for your hard work 🤍 Another contributer works on it in PR #247, I'll close this to avoid duplicate work.
However, we would love to see your contributions in the future 👀🤍

@moshams272 moshams272 closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

page(branding): should force light/dark. bg on icon

2 participants

@Ayush-AM @moshams272